head	1.2;
access;
symbols
	pkgsrc-2013Q2:1.2.0.44
	pkgsrc-2013Q2-base:1.2
	pkgsrc-2012Q4:1.2.0.42
	pkgsrc-2012Q4-base:1.2
	pkgsrc-2011Q4:1.2.0.40
	pkgsrc-2011Q4-base:1.2
	pkgsrc-2011Q2:1.2.0.38
	pkgsrc-2011Q2-base:1.2
	pkgsrc-2009Q4:1.2.0.36
	pkgsrc-2009Q4-base:1.2
	pkgsrc-2008Q4:1.2.0.34
	pkgsrc-2008Q4-base:1.2
	pkgsrc-2008Q3:1.2.0.32
	pkgsrc-2008Q3-base:1.2
	cube-native-xorg:1.2.0.30
	cube-native-xorg-base:1.2
	pkgsrc-2008Q2:1.2.0.28
	pkgsrc-2008Q2-base:1.2
	pkgsrc-2008Q1:1.2.0.26
	pkgsrc-2008Q1-base:1.2
	pkgsrc-2007Q4:1.2.0.24
	pkgsrc-2007Q4-base:1.2
	pkgsrc-2007Q3:1.2.0.22
	pkgsrc-2007Q3-base:1.2
	pkgsrc-2007Q2:1.2.0.20
	pkgsrc-2007Q2-base:1.2
	pkgsrc-2007Q1:1.2.0.18
	pkgsrc-2007Q1-base:1.2
	pkgsrc-2006Q4:1.2.0.16
	pkgsrc-2006Q4-base:1.2
	pkgsrc-2006Q3:1.2.0.14
	pkgsrc-2006Q3-base:1.2
	pkgsrc-2006Q2:1.2.0.12
	pkgsrc-2006Q2-base:1.2
	pkgsrc-2006Q1:1.2.0.10
	pkgsrc-2006Q1-base:1.2
	pkgsrc-2005Q4:1.2.0.8
	pkgsrc-2005Q4-base:1.2
	pkgsrc-2005Q3:1.2.0.6
	pkgsrc-2005Q3-base:1.2
	pkgsrc-2005Q2:1.2.0.4
	pkgsrc-2005Q2-base:1.2
	pkgsrc-2005Q1:1.2.0.2
	pkgsrc-2005Q1-base:1.2
	pkgsrc-2004Q4:1.1.0.18
	pkgsrc-2004Q4-base:1.1
	pkgsrc-2004Q3:1.1.0.16
	pkgsrc-2004Q3-base:1.1
	pkgsrc-2004Q2:1.1.0.14
	pkgsrc-2004Q2-base:1.1
	pkgsrc-2004Q1:1.1.0.12
	pkgsrc-2004Q1-base:1.1
	pkgsrc-2003Q4:1.1.0.10
	pkgsrc-2003Q4-base:1.1
	netbsd-1-6-1:1.1.0.6
	netbsd-1-6-1-base:1.1
	netbsd-1-6:1.1.0.8
	netbsd-1-6-RELEASE-base:1.1
	pkgviews:1.1.0.4
	pkgviews-base:1.1
	buildlink2:1.1.0.2
	buildlink2-base:1.1
	netbsd-1-5-PATCH003:1.1;
locks; strict;
comment	@# @;


1.2
date	2005.01.03.14.32.31;	author wiz;	state dead;
branches;
next	1.1;

1.1
date	2001.11.13.21.25.55;	author jlam;	state Exp;
branches;
next	;


desc
@@


1.2
log
@Remove KDE2 packages (and their dependencies) as proposed on tech-pkg.
@
text
@$NetBSD: patch-ae,v 1.1 2001/11/13 21:25:55 jlam Exp $

--- libkdenetwork/kpgpbase.cpp.orig	Tue Sep  4 19:20:45 2001
+++ libkdenetwork/kpgpbase.cpp
@@@@ -265,7 +265,28 @@@@
               //kdDebug(5100) << "Read " << len << " bytes from pout[0]" << endl;
               str[len] ='\0';
               output += str;
-            }
+            } else {
+	      /*
+	       * Apparently, on NetBSD when the child dies, the pipe begins
+	       * receiving empty data packets *before* waitpid() has signaled
+	       * that the child has died.  Also, notice that this happens
+	       * without any error bit being set in pollfd.revents (is this a
+	       * NetBSD bug???).  Notice that these anomalous packets exist
+	       * according to poll(), but have length 0 according to read().
+	       * Thus, kde can remain stuck inside this loop.
+	       *
+	       * A solution to this problem is to get out of the inner loop
+	       * when read() returns <=0.  In this way, kde has another chance
+	       * to call waitpid() to check if the child has died -- and this
+	       * time the call should succeed.
+	       *
+	       * Setting POLLHUP in pollfd.revents is not necessary, but I just
+	       * like the idea of signaling that something strange has
+	       * happened.
+	       */
+              pollout.revents |= POLLHUP;
+              break;
+	    }
           }
         }
         else if (pollstatus == -1) {
@@@@ -288,7 +309,28 @@@@
               //kdDebug(5100) << "Read " << len << " bytes from perr[0]" << endl;
               str[len] ='\0';
               info += str;
-            }
+            } else {
+	      /*
+	       * Apparently, on NetBSD when the child dies, the pipe begins
+	       * receiving empty data packets *before* waitpid() has signaled
+	       * that the child has died.  Also, notice that this happens
+	       * without any error bit being set in pollfd.revents (is this a
+	       * NetBSD bug???).  Notice that these anomalous packets exist
+	       * according to poll(), but have length 0 according to read().
+	       * Thus, kde can remain stuck inside this loop.
+	       *
+	       * A solution to this problem is to get out of the inner loop
+	       * when read() returns <=0.  In this way, kde has another chance
+	       * to call waitpid() to check if the child has died -- and this
+	       * time the call should succeed.
+	       *
+	       * Setting POLLHUP in pollfd.revents is not necessary, but I just
+	       * like the idea of signaling that something strange has
+	       * happened.
+	       */
+              pollerr.revents |= POLLHUP;
+              break;
+	    }
           }
         }
         else if (pollstatus == -1) {
@


1.1
log
@* Strongly buildlinkify.
* Use qt2-designer-kde for a uic that understands KDE2 widgets.
* Fix problem noted by Marcello Balduccini <marcello.balduccini@@ttu.edu>
  in how kpgp handles pipes with child processes -- prevents kpgp from
  remaining stuck while waiting for the child pgp process to terminate.
@
text
@d1 1
a1 1
$NetBSD$
@