head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.6 netbsd-11-0-RC3:1.1.1.6 netbsd-11-0-RC2:1.1.1.6 netbsd-11-0-RC1:1.1.1.6 perseant-exfatfs-base-20250801:1.1.1.6 netbsd-11:1.1.1.6.0.10 netbsd-11-base:1.1.1.6 netbsd-10-1-RELEASE:1.1.1.6 perseant-exfatfs-base-20240630:1.1.1.6 perseant-exfatfs:1.1.1.6.0.8 perseant-exfatfs-base:1.1.1.6 netbsd-8-3-RELEASE:1.1.1.4 netbsd-9-4-RELEASE:1.1.1.5 netbsd-10-0-RELEASE:1.1.1.6 netbsd-10-0-RC6:1.1.1.6 netbsd-10-0-RC5:1.1.1.6 netbsd-10-0-RC4:1.1.1.6 netbsd-10-0-RC3:1.1.1.6 netbsd-10-0-RC2:1.1.1.6 netbsd-10-0-RC1:1.1.1.6 netbsd-10:1.1.1.6.0.6 netbsd-10-base:1.1.1.6 netbsd-9-3-RELEASE:1.1.1.5 cjep_sun2x:1.1.1.6.0.4 cjep_sun2x-base:1.1.1.6 cjep_staticlib_x-base1:1.1.1.6 netbsd-9-2-RELEASE:1.1.1.5 cjep_staticlib_x:1.1.1.6.0.2 cjep_staticlib_x-base:1.1.1.6 netbsd-9-1-RELEASE:1.1.1.5 phil-wifi-20200421:1.1.1.6 phil-wifi-20200411:1.1.1.6 phil-wifi-20200406:1.1.1.6 netbsd-8-2-RELEASE:1.1.1.4 netbsd-9-0-RELEASE:1.1.1.5 netbsd-9-0-RC2:1.1.1.5 netbsd-9-0-RC1:1.1.1.5 netbsd-9:1.1.1.5.0.2 netbsd-9-base:1.1.1.5 phil-wifi-20190609:1.1.1.5 netbsd-8-1-RELEASE:1.1.1.4 netbsd-8-1-RC1:1.1.1.4 pgoyette-compat-merge-20190127:1.1.1.4.14.1 pgoyette-compat-20190127:1.1.1.5 pgoyette-compat-20190118:1.1.1.5 pgoyette-compat-1226:1.1.1.5 pgoyette-compat-1126:1.1.1.5 pgoyette-compat-1020:1.1.1.5 pgoyette-compat-0930:1.1.1.5 pgoyette-compat-0906:1.1.1.5 netbsd-7-2-RELEASE:1.1.1.3 pgoyette-compat-0728:1.1.1.5 clang-337282:1.1.1.5 netbsd-8-0-RELEASE:1.1.1.4 phil-wifi:1.1.1.4.0.16 phil-wifi-base:1.1.1.4 pgoyette-compat-0625:1.1.1.4 netbsd-8-0-RC2:1.1.1.4 pgoyette-compat-0521:1.1.1.4 pgoyette-compat-0502:1.1.1.4 pgoyette-compat-0422:1.1.1.4 netbsd-8-0-RC1:1.1.1.4 pgoyette-compat-0415:1.1.1.4 pgoyette-compat-0407:1.1.1.4 pgoyette-compat-0330:1.1.1.4 pgoyette-compat-0322:1.1.1.4 pgoyette-compat-0315:1.1.1.4 netbsd-7-1-2-RELEASE:1.1.1.3 pgoyette-compat:1.1.1.4.0.14 pgoyette-compat-base:1.1.1.4 netbsd-7-1-1-RELEASE:1.1.1.3 clang-319952:1.1.1.4 matt-nb8-mediatek:1.1.1.4.0.12 matt-nb8-mediatek-base:1.1.1.4 clang-309604:1.1.1.4 perseant-stdc-iso10646:1.1.1.4.0.10 perseant-stdc-iso10646-base:1.1.1.4 netbsd-8:1.1.1.4.0.8 netbsd-8-base:1.1.1.4 prg-localcount2-base3:1.1.1.4 prg-localcount2-base2:1.1.1.4 prg-localcount2-base1:1.1.1.4 prg-localcount2:1.1.1.4.0.6 prg-localcount2-base:1.1.1.4 pgoyette-localcount-20170426:1.1.1.4 bouyer-socketcan-base1:1.1.1.4 pgoyette-localcount-20170320:1.1.1.4 netbsd-7-1:1.1.1.3.0.10 netbsd-7-1-RELEASE:1.1.1.3 netbsd-7-1-RC2:1.1.1.3 clang-294123:1.1.1.4 netbsd-7-nhusb-base-20170116:1.1.1.3 bouyer-socketcan:1.1.1.4.0.4 bouyer-socketcan-base:1.1.1.4 clang-291444:1.1.1.4 pgoyette-localcount-20170107:1.1.1.4 netbsd-7-1-RC1:1.1.1.3 pgoyette-localcount-20161104:1.1.1.4 netbsd-7-0-2-RELEASE:1.1.1.3 localcount-20160914:1.1.1.4 netbsd-7-nhusb:1.1.1.3.0.8 netbsd-7-nhusb-base:1.1.1.3 clang-280599:1.1.1.4 pgoyette-localcount-20160806:1.1.1.4 pgoyette-localcount-20160726:1.1.1.4 pgoyette-localcount:1.1.1.4.0.2 pgoyette-localcount-base:1.1.1.4 netbsd-7-0-1-RELEASE:1.1.1.3 clang-261930:1.1.1.4 netbsd-7-0:1.1.1.3.0.6 netbsd-7-0-RELEASE:1.1.1.3 netbsd-7-0-RC3:1.1.1.3 netbsd-7-0-RC2:1.1.1.3 netbsd-7-0-RC1:1.1.1.3 clang-237755:1.1.1.3 clang-232565:1.1.1.3 clang-227398:1.1.1.3 tls-maxphys-base:1.1.1.3 tls-maxphys:1.1.1.3.0.4 netbsd-7:1.1.1.3.0.2 netbsd-7-base:1.1.1.3 clang-215315:1.1.1.3 clang-209886:1.1.1.3 yamt-pagecache:1.1.1.2.0.4 yamt-pagecache-base9:1.1.1.2 tls-earlyentropy:1.1.1.2.0.2 tls-earlyentropy-base:1.1.1.3 riastradh-xf86-video-intel-2-7-1-pre-2-21-15:1.1.1.2 riastradh-drm2-base3:1.1.1.2 clang-202566:1.1.1.2 clang-201163:1.1.1.1 clang-199312:1.1.1.1 clang-198450:1.1.1.1 clang-196603:1.1.1.1 clang-195771:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2013.11.28.14.14.52; author joerg; state Exp; branches 1.1.1.1; next ; commitid ow8OybrawrB1f3fx; 1.1.1.1 date 2013.11.28.14.14.52; author joerg; state Exp; branches; next 1.1.1.2; commitid ow8OybrawrB1f3fx; 1.1.1.2 date 2014.03.04.19.55.01; author joerg; state Exp; branches 1.1.1.2.2.1 1.1.1.2.4.1; next 1.1.1.3; commitid 29z1hJonZISIXprx; 1.1.1.3 date 2014.05.30.18.14.44; author joerg; state Exp; branches 1.1.1.3.4.1; next 1.1.1.4; commitid 8q0kdlBlCn09GACx; 1.1.1.4 date 2016.02.27.22.12.06; author joerg; state Exp; branches 1.1.1.4.14.1 1.1.1.4.16.1; next 1.1.1.5; commitid tIimz3oDlh1NpBWy; 1.1.1.5 date 2018.07.17.18.31.07; author joerg; state Exp; branches; next 1.1.1.6; commitid wDzL46ALjrCZgwKA; 1.1.1.6 date 2019.11.13.22.19.28; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.2.2.1 date 2014.08.10.07.08.10; author tls; state Exp; branches; next ; commitid t01A1TLTYxkpGMLx; 1.1.1.2.4.1 date 2014.03.04.19.55.01; author yamt; state dead; branches; next 1.1.1.2.4.2; commitid WSrDtL5nYAUyiyBx; 1.1.1.2.4.2 date 2014.05.22.16.18.31; author yamt; state Exp; branches; next ; commitid WSrDtL5nYAUyiyBx; 1.1.1.3.4.1 date 2014.05.30.18.14.44; author tls; state dead; branches; next 1.1.1.3.4.2; commitid jTnpym9Qu0o4R1Nx; 1.1.1.3.4.2 date 2014.08.19.23.47.31; author tls; state Exp; branches; next ; commitid jTnpym9Qu0o4R1Nx; 1.1.1.4.14.1 date 2018.07.28.04.33.23; author pgoyette; state Exp; branches; next ; commitid 1UP1xAIUxv1ZgRLA; 1.1.1.4.16.1 date 2019.06.10.21.45.28; author christos; state Exp; branches; next 1.1.1.4.16.2; commitid jtc8rnCzWiEEHGqB; 1.1.1.4.16.2 date 2020.04.13.07.46.39; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//== ObjCContainersASTChecker.cpp - CoreFoundation containers API *- C++ -*-==// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // An AST checker that looks for common pitfalls when using 'CFArray', // 'CFDictionary', 'CFSet' APIs. // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/AST/StmtVisitor.h" #include "clang/Analysis/AnalysisContext.h" #include "clang/Basic/TargetInfo.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h" #include "llvm/ADT/SmallString.h" #include "llvm/Support/raw_ostream.h" using namespace clang; using namespace ento; namespace { class WalkAST : public StmtVisitor { BugReporter &BR; AnalysisDeclContext* AC; ASTContext &ASTC; uint64_t PtrWidth; /// Check if the type has pointer size (very conservative). inline bool isPointerSize(const Type *T) { if (!T) return true; if (T->isIncompleteType()) return true; return (ASTC.getTypeSize(T) == PtrWidth); } /// Check if the type is a pointer/array to pointer sized values. inline bool hasPointerToPointerSizedType(const Expr *E) { QualType T = E->getType(); // The type could be either a pointer or array. const Type *TP = T.getTypePtr(); QualType PointeeT = TP->getPointeeType(); if (!PointeeT.isNull()) { // If the type is a pointer to an array, check the size of the array // elements. To avoid false positives coming from assumption that the // values x and &x are equal when x is an array. if (const Type *TElem = PointeeT->getArrayElementTypeNoTypeQual()) if (isPointerSize(TElem)) return true; // Else, check the pointee size. return isPointerSize(PointeeT.getTypePtr()); } if (const Type *TElem = TP->getArrayElementTypeNoTypeQual()) return isPointerSize(TElem); // The type must be an array/pointer type. // This could be a null constant, which is allowed. if (E->isNullPointerConstant(ASTC, Expr::NPC_ValueDependentIsNull)) return true; return false; } public: WalkAST(BugReporter &br, AnalysisDeclContext* ac) : BR(br), AC(ac), ASTC(AC->getASTContext()), PtrWidth(ASTC.getTargetInfo().getPointerWidth(0)) {} // Statement visitor methods. void VisitChildren(Stmt *S); void VisitStmt(Stmt *S) { VisitChildren(S); } void VisitCallExpr(CallExpr *CE); }; } // end anonymous namespace static StringRef getCalleeName(CallExpr *CE) { const FunctionDecl *FD = CE->getDirectCallee(); if (!FD) return StringRef(); IdentifierInfo *II = FD->getIdentifier(); if (!II) // if no identifier, not a simple C function return StringRef(); return II->getName(); } void WalkAST::VisitCallExpr(CallExpr *CE) { StringRef Name = getCalleeName(CE); if (Name.empty()) return; const Expr *Arg = 0; unsigned ArgNum; if (Name.equals("CFArrayCreate") || Name.equals("CFSetCreate")) { if (CE->getNumArgs() != 4) return; ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) return; } else if (Name.equals("CFDictionaryCreate")) { if (CE->getNumArgs() != 6) return; // Check first argument. ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) { // Check second argument. ArgNum = 2; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) // Both are good, return. return; } } if (Arg) { assert(ArgNum == 1 || ArgNum == 2); SmallString<64> BufName; llvm::raw_svector_ostream OsName(BufName); OsName << " Invalid use of '" << Name << "'" ; SmallString<256> Buf; llvm::raw_svector_ostream Os(Buf); // Use "second" and "third" since users will expect 1-based indexing // for parameter names when mentioned in prose. Os << " The "<< ((ArgNum == 1) ? "second" : "third") << " argument to '" << Name << "' must be a C array of pointer-sized values, not '" << Arg->getType().getAsString() << "'"; PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC); BR.EmitBasicReport(AC->getDecl(), OsName.str(), categories::CoreFoundationObjectiveC, Os.str(), CELoc, Arg->getSourceRange()); } // Recurse and check children. VisitChildren(CE); } void WalkAST::VisitChildren(Stmt *S) { for (Stmt::child_iterator I = S->child_begin(), E = S->child_end(); I!=E; ++I) if (Stmt *child = *I) Visit(child); } namespace { class ObjCContainersASTChecker : public Checker { public: void checkASTCodeBody(const Decl *D, AnalysisManager& Mgr, BugReporter &BR) const { WalkAST walker(BR, Mgr.getAnalysisDeclContext(D)); walker.Visit(D->getBody()); } }; } void ento::registerObjCContainersASTChecker(CheckerManager &mgr) { mgr.registerChecker(); } @ 1.1.1.1 log @Import Clang 3.4rc1 r195771. @ text @@ 1.1.1.2 log @Import Clang 3.5svn r202566. @ text @a29 1 const CheckerBase *Checker; d74 3 a76 3 WalkAST(BugReporter &br, const CheckerBase *checker, AnalysisDeclContext *ac) : BR(br), Checker(checker), AC(ac), ASTC(AC->getASTContext()), PtrWidth(ASTC.getTargetInfo().getPointerWidth(0)) {} d145 3 a147 3 BR.EmitBasicReport(AC->getDecl(), Checker, OsName.str(), categories::CoreFoundationObjectiveC, Os.str(), CELoc, Arg->getSourceRange()); d166 1 a166 1 WalkAST walker(BR, this, Mgr.getAnalysisDeclContext(D)); @ 1.1.1.2.2.1 log @Rebase. @ text @d103 1 a103 1 const Expr *Arg = nullptr; @ 1.1.1.3 log @Import Clang 3.5svn r209886. @ text @d103 1 a103 1 const Expr *Arg = nullptr; @ 1.1.1.4 log @Import Clang 3.8.0rc3 r261930. @ text @d69 3 a71 2 return static_cast( E->isNullPointerConstant(ASTC, Expr::NPC_ValueDependentIsNull)); d156 3 a158 3 for (Stmt *Child : S->children()) if (Child) Visit(Child); @ 1.1.1.4.16.1 log @Sync with HEAD @ text @d16 1 a16 1 #include "clang/Analysis/AnalysisDeclContext.h" @ 1.1.1.4.16.2 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.4.14.1 log @Sync with HEAD @ text @d16 1 a16 1 #include "clang/Analysis/AnalysisDeclContext.h" @ 1.1.1.5 log @Import clang r337282 from trunk @ text @d16 1 a16 1 #include "clang/Analysis/AnalysisDeclContext.h" @ 1.1.1.6 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.3.4.1 log @file ObjCContainersASTChecker.cpp was added on branch tls-maxphys on 2014-08-19 23:47:31 +0000 @ text @d1 175 @ 1.1.1.3.4.2 log @Rebase to HEAD as of a few days ago. @ text @a0 175 //== ObjCContainersASTChecker.cpp - CoreFoundation containers API *- C++ -*-==// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // An AST checker that looks for common pitfalls when using 'CFArray', // 'CFDictionary', 'CFSet' APIs. // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/AST/StmtVisitor.h" #include "clang/Analysis/AnalysisContext.h" #include "clang/Basic/TargetInfo.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h" #include "llvm/ADT/SmallString.h" #include "llvm/Support/raw_ostream.h" using namespace clang; using namespace ento; namespace { class WalkAST : public StmtVisitor { BugReporter &BR; const CheckerBase *Checker; AnalysisDeclContext* AC; ASTContext &ASTC; uint64_t PtrWidth; /// Check if the type has pointer size (very conservative). inline bool isPointerSize(const Type *T) { if (!T) return true; if (T->isIncompleteType()) return true; return (ASTC.getTypeSize(T) == PtrWidth); } /// Check if the type is a pointer/array to pointer sized values. inline bool hasPointerToPointerSizedType(const Expr *E) { QualType T = E->getType(); // The type could be either a pointer or array. const Type *TP = T.getTypePtr(); QualType PointeeT = TP->getPointeeType(); if (!PointeeT.isNull()) { // If the type is a pointer to an array, check the size of the array // elements. To avoid false positives coming from assumption that the // values x and &x are equal when x is an array. if (const Type *TElem = PointeeT->getArrayElementTypeNoTypeQual()) if (isPointerSize(TElem)) return true; // Else, check the pointee size. return isPointerSize(PointeeT.getTypePtr()); } if (const Type *TElem = TP->getArrayElementTypeNoTypeQual()) return isPointerSize(TElem); // The type must be an array/pointer type. // This could be a null constant, which is allowed. if (E->isNullPointerConstant(ASTC, Expr::NPC_ValueDependentIsNull)) return true; return false; } public: WalkAST(BugReporter &br, const CheckerBase *checker, AnalysisDeclContext *ac) : BR(br), Checker(checker), AC(ac), ASTC(AC->getASTContext()), PtrWidth(ASTC.getTargetInfo().getPointerWidth(0)) {} // Statement visitor methods. void VisitChildren(Stmt *S); void VisitStmt(Stmt *S) { VisitChildren(S); } void VisitCallExpr(CallExpr *CE); }; } // end anonymous namespace static StringRef getCalleeName(CallExpr *CE) { const FunctionDecl *FD = CE->getDirectCallee(); if (!FD) return StringRef(); IdentifierInfo *II = FD->getIdentifier(); if (!II) // if no identifier, not a simple C function return StringRef(); return II->getName(); } void WalkAST::VisitCallExpr(CallExpr *CE) { StringRef Name = getCalleeName(CE); if (Name.empty()) return; const Expr *Arg = nullptr; unsigned ArgNum; if (Name.equals("CFArrayCreate") || Name.equals("CFSetCreate")) { if (CE->getNumArgs() != 4) return; ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) return; } else if (Name.equals("CFDictionaryCreate")) { if (CE->getNumArgs() != 6) return; // Check first argument. ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) { // Check second argument. ArgNum = 2; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) // Both are good, return. return; } } if (Arg) { assert(ArgNum == 1 || ArgNum == 2); SmallString<64> BufName; llvm::raw_svector_ostream OsName(BufName); OsName << " Invalid use of '" << Name << "'" ; SmallString<256> Buf; llvm::raw_svector_ostream Os(Buf); // Use "second" and "third" since users will expect 1-based indexing // for parameter names when mentioned in prose. Os << " The "<< ((ArgNum == 1) ? "second" : "third") << " argument to '" << Name << "' must be a C array of pointer-sized values, not '" << Arg->getType().getAsString() << "'"; PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC); BR.EmitBasicReport(AC->getDecl(), Checker, OsName.str(), categories::CoreFoundationObjectiveC, Os.str(), CELoc, Arg->getSourceRange()); } // Recurse and check children. VisitChildren(CE); } void WalkAST::VisitChildren(Stmt *S) { for (Stmt::child_iterator I = S->child_begin(), E = S->child_end(); I!=E; ++I) if (Stmt *child = *I) Visit(child); } namespace { class ObjCContainersASTChecker : public Checker { public: void checkASTCodeBody(const Decl *D, AnalysisManager& Mgr, BugReporter &BR) const { WalkAST walker(BR, this, Mgr.getAnalysisDeclContext(D)); walker.Visit(D->getBody()); } }; } void ento::registerObjCContainersASTChecker(CheckerManager &mgr) { mgr.registerChecker(); } @ 1.1.1.2.4.1 log @file ObjCContainersASTChecker.cpp was added on branch yamt-pagecache on 2014-05-22 16:18:31 +0000 @ text @d1 175 @ 1.1.1.2.4.2 log @sync with head. for a reference, the tree before this commit was tagged as yamt-pagecache-tag8. this commit was splitted into small chunks to avoid a limitation of cvs. ("Protocol error: too many arguments") @ text @a0 175 //== ObjCContainersASTChecker.cpp - CoreFoundation containers API *- C++ -*-==// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // An AST checker that looks for common pitfalls when using 'CFArray', // 'CFDictionary', 'CFSet' APIs. // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/AST/StmtVisitor.h" #include "clang/Analysis/AnalysisContext.h" #include "clang/Basic/TargetInfo.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h" #include "llvm/ADT/SmallString.h" #include "llvm/Support/raw_ostream.h" using namespace clang; using namespace ento; namespace { class WalkAST : public StmtVisitor { BugReporter &BR; const CheckerBase *Checker; AnalysisDeclContext* AC; ASTContext &ASTC; uint64_t PtrWidth; /// Check if the type has pointer size (very conservative). inline bool isPointerSize(const Type *T) { if (!T) return true; if (T->isIncompleteType()) return true; return (ASTC.getTypeSize(T) == PtrWidth); } /// Check if the type is a pointer/array to pointer sized values. inline bool hasPointerToPointerSizedType(const Expr *E) { QualType T = E->getType(); // The type could be either a pointer or array. const Type *TP = T.getTypePtr(); QualType PointeeT = TP->getPointeeType(); if (!PointeeT.isNull()) { // If the type is a pointer to an array, check the size of the array // elements. To avoid false positives coming from assumption that the // values x and &x are equal when x is an array. if (const Type *TElem = PointeeT->getArrayElementTypeNoTypeQual()) if (isPointerSize(TElem)) return true; // Else, check the pointee size. return isPointerSize(PointeeT.getTypePtr()); } if (const Type *TElem = TP->getArrayElementTypeNoTypeQual()) return isPointerSize(TElem); // The type must be an array/pointer type. // This could be a null constant, which is allowed. if (E->isNullPointerConstant(ASTC, Expr::NPC_ValueDependentIsNull)) return true; return false; } public: WalkAST(BugReporter &br, const CheckerBase *checker, AnalysisDeclContext *ac) : BR(br), Checker(checker), AC(ac), ASTC(AC->getASTContext()), PtrWidth(ASTC.getTargetInfo().getPointerWidth(0)) {} // Statement visitor methods. void VisitChildren(Stmt *S); void VisitStmt(Stmt *S) { VisitChildren(S); } void VisitCallExpr(CallExpr *CE); }; } // end anonymous namespace static StringRef getCalleeName(CallExpr *CE) { const FunctionDecl *FD = CE->getDirectCallee(); if (!FD) return StringRef(); IdentifierInfo *II = FD->getIdentifier(); if (!II) // if no identifier, not a simple C function return StringRef(); return II->getName(); } void WalkAST::VisitCallExpr(CallExpr *CE) { StringRef Name = getCalleeName(CE); if (Name.empty()) return; const Expr *Arg = 0; unsigned ArgNum; if (Name.equals("CFArrayCreate") || Name.equals("CFSetCreate")) { if (CE->getNumArgs() != 4) return; ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) return; } else if (Name.equals("CFDictionaryCreate")) { if (CE->getNumArgs() != 6) return; // Check first argument. ArgNum = 1; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) { // Check second argument. ArgNum = 2; Arg = CE->getArg(ArgNum)->IgnoreParenCasts(); if (hasPointerToPointerSizedType(Arg)) // Both are good, return. return; } } if (Arg) { assert(ArgNum == 1 || ArgNum == 2); SmallString<64> BufName; llvm::raw_svector_ostream OsName(BufName); OsName << " Invalid use of '" << Name << "'" ; SmallString<256> Buf; llvm::raw_svector_ostream Os(Buf); // Use "second" and "third" since users will expect 1-based indexing // for parameter names when mentioned in prose. Os << " The "<< ((ArgNum == 1) ? "second" : "third") << " argument to '" << Name << "' must be a C array of pointer-sized values, not '" << Arg->getType().getAsString() << "'"; PathDiagnosticLocation CELoc = PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), AC); BR.EmitBasicReport(AC->getDecl(), Checker, OsName.str(), categories::CoreFoundationObjectiveC, Os.str(), CELoc, Arg->getSourceRange()); } // Recurse and check children. VisitChildren(CE); } void WalkAST::VisitChildren(Stmt *S) { for (Stmt::child_iterator I = S->child_begin(), E = S->child_end(); I!=E; ++I) if (Stmt *child = *I) Visit(child); } namespace { class ObjCContainersASTChecker : public Checker { public: void checkASTCodeBody(const Decl *D, AnalysisManager& Mgr, BugReporter &BR) const { WalkAST walker(BR, this, Mgr.getAnalysisDeclContext(D)); walker.Visit(D->getBody()); } }; } void ento::registerObjCContainersASTChecker(CheckerManager &mgr) { mgr.registerChecker(); } @