head	1.1;
access;
symbols;
locks; strict;
comment	@// @;


1.1
date	2026.08.11.14.21.47;	author riastradh;	state Exp;
branches;
next	;
commitid	pftVZIdqGCIraeRG;


desc
@@


1.1
log
@net/transmission: Fix ctype abuse.

Excluding the third-party/ directory for now -- lot more patching to do
for that.

PR pkg/60574: transmission-daemon etc. abort on invalid toupper(3) call
@
text
@$NetBSD$

Fix ctype(3) abuse.
https://gnats.NetBSD.org/60574

--- libtransmission/crypto-utils.cc.orig	2024-05-29 01:38:35.000000000 +0000
+++ libtransmission/crypto-utils.cc
@@@@ -179,8 +179,8 @@@@ constexpr void tr_hex_to_binary(char con
 
     for (size_t i = 0; i < byte_length; ++i)
     {
-        auto const upper_nibble = Hex.find(std::tolower(*input++));
-        auto const lower_nibble = Hex.find(std::tolower(*input++));
+        auto const upper_nibble = Hex.find(std::tolower(static_cast<unsigned char>(*input++)));
+        auto const lower_nibble = Hex.find(std::tolower(static_cast<unsigned char>(*input++)));
         *output++ = (uint8_t)((upper_nibble << 4) | lower_nibble);
     }
 }
@