head 1.1; access; symbols pkgsrc-2026Q1:1.1.0.112 pkgsrc-2026Q1-base:1.1 pkgsrc-2025Q4:1.1.0.110 pkgsrc-2025Q4-base:1.1 pkgsrc-2025Q3:1.1.0.108 pkgsrc-2025Q3-base:1.1 pkgsrc-2025Q2:1.1.0.106 pkgsrc-2025Q2-base:1.1 pkgsrc-2025Q1:1.1.0.104 pkgsrc-2025Q1-base:1.1 pkgsrc-2024Q4:1.1.0.102 pkgsrc-2024Q4-base:1.1 pkgsrc-2024Q3:1.1.0.100 pkgsrc-2024Q3-base:1.1 pkgsrc-2024Q2:1.1.0.98 pkgsrc-2024Q2-base:1.1 pkgsrc-2024Q1:1.1.0.96 pkgsrc-2024Q1-base:1.1 pkgsrc-2023Q4:1.1.0.94 pkgsrc-2023Q4-base:1.1 pkgsrc-2023Q3:1.1.0.92 pkgsrc-2023Q3-base:1.1 pkgsrc-2023Q2:1.1.0.90 pkgsrc-2023Q2-base:1.1 pkgsrc-2023Q1:1.1.0.88 pkgsrc-2023Q1-base:1.1 pkgsrc-2022Q4:1.1.0.86 pkgsrc-2022Q4-base:1.1 pkgsrc-2022Q3:1.1.0.84 pkgsrc-2022Q3-base:1.1 pkgsrc-2022Q2:1.1.0.82 pkgsrc-2022Q2-base:1.1 pkgsrc-2022Q1:1.1.0.80 pkgsrc-2022Q1-base:1.1 pkgsrc-2021Q4:1.1.0.78 pkgsrc-2021Q4-base:1.1 pkgsrc-2021Q3:1.1.0.76 pkgsrc-2021Q3-base:1.1 pkgsrc-2021Q2:1.1.0.74 pkgsrc-2021Q2-base:1.1 pkgsrc-2021Q1:1.1.0.72 pkgsrc-2021Q1-base:1.1 pkgsrc-2020Q4:1.1.0.70 pkgsrc-2020Q4-base:1.1 pkgsrc-2020Q3:1.1.0.68 pkgsrc-2020Q3-base:1.1 pkgsrc-2020Q2:1.1.0.64 pkgsrc-2020Q2-base:1.1 pkgsrc-2020Q1:1.1.0.44 pkgsrc-2020Q1-base:1.1 pkgsrc-2019Q4:1.1.0.66 pkgsrc-2019Q4-base:1.1 pkgsrc-2019Q3:1.1.0.62 pkgsrc-2019Q3-base:1.1 pkgsrc-2019Q2:1.1.0.60 pkgsrc-2019Q2-base:1.1 pkgsrc-2019Q1:1.1.0.58 pkgsrc-2019Q1-base:1.1 pkgsrc-2018Q4:1.1.0.56 pkgsrc-2018Q4-base:1.1 pkgsrc-2018Q3:1.1.0.54 pkgsrc-2018Q3-base:1.1 pkgsrc-2018Q2:1.1.0.52 pkgsrc-2018Q2-base:1.1 pkgsrc-2018Q1:1.1.0.50 pkgsrc-2018Q1-base:1.1 pkgsrc-2017Q4:1.1.0.48 pkgsrc-2017Q4-base:1.1 pkgsrc-2017Q3:1.1.0.46 pkgsrc-2017Q3-base:1.1 pkgsrc-2017Q2:1.1.0.42 pkgsrc-2017Q2-base:1.1 pkgsrc-2017Q1:1.1.0.40 pkgsrc-2017Q1-base:1.1 pkgsrc-2016Q4:1.1.0.38 pkgsrc-2016Q4-base:1.1 pkgsrc-2016Q3:1.1.0.36 pkgsrc-2016Q3-base:1.1 pkgsrc-2016Q2:1.1.0.34 pkgsrc-2016Q2-base:1.1 pkgsrc-2016Q1:1.1.0.32 pkgsrc-2016Q1-base:1.1 pkgsrc-2015Q4:1.1.0.30 pkgsrc-2015Q4-base:1.1 pkgsrc-2015Q3:1.1.0.28 pkgsrc-2015Q3-base:1.1 pkgsrc-2015Q2:1.1.0.26 pkgsrc-2015Q2-base:1.1 pkgsrc-2015Q1:1.1.0.24 pkgsrc-2015Q1-base:1.1 pkgsrc-2014Q4:1.1.0.22 pkgsrc-2014Q4-base:1.1 pkgsrc-2014Q3:1.1.0.20 pkgsrc-2014Q3-base:1.1 pkgsrc-2014Q2:1.1.0.18 pkgsrc-2014Q2-base:1.1 pkgsrc-2014Q1:1.1.0.16 pkgsrc-2014Q1-base:1.1 pkgsrc-2013Q4:1.1.0.14 pkgsrc-2013Q4-base:1.1 pkgsrc-2013Q3:1.1.0.12 pkgsrc-2013Q3-base:1.1 pkgsrc-2013Q2:1.1.0.10 pkgsrc-2013Q2-base:1.1 pkgsrc-2013Q1:1.1.0.8 pkgsrc-2013Q1-base:1.1 pkgsrc-2012Q4:1.1.0.6 pkgsrc-2012Q4-base:1.1 pkgsrc-2012Q3:1.1.0.4 pkgsrc-2012Q3-base:1.1 pkgsrc-2012Q2:1.1.0.2 pkgsrc-2012Q2-base:1.1; locks; strict; comment @# @; 1.1 date 2012.05.10.20.53.30; author dholland; state Exp; branches; next ; desc @@ 1.1 log @Pass -Wall. Fix a number of minor bugs and possibly some major ones. Should also fix clang build. PKGREVISION++ @ text @$NetBSD$ - don't use implicit int - const correctness required by existing const declarations - fix uninitialized variable bug on error path, caught by gcc --- src/exec.c~ 2012-05-10 19:25:36.000000000 +0000 +++ src/exec.c @@@@ -11,7 +11,7 @@@@ /* namedcmd: execute a named command even if it is not bound */ -PASCAL NEAR namedcmd(f, n) +int PASCAL NEAR namedcmd(f, n) int f, n; /* command arguments [passed through to command executed] */ @@@@ -61,7 +61,7 @@@@ int f, n; /* command arguments [passed t /* execcmd: Execute a command line command to be typed in by the user */ -PASCAL NEAR execcmd(f, n) +int PASCAL NEAR execcmd(f, n) int f, n; /* default Flag and Numeric argument */ @@@@ -88,7 +88,7 @@@@ int f, n; /* default Flag and Numeric ar */ -PASCAL NEAR docmd(cline) +int PASCAL NEAR docmd(cline) char *cline; /* command line to execute */ @@@@ -238,7 +238,7 @@@@ int size; /* maximum size of token */ return(src); } -PASCAL NEAR macarg(tok) /* get a macro line argument */ +int PASCAL NEAR macarg(tok) /* get a macro line argument */ char *tok; /* buffer to place argument */ @@@@ -255,7 +255,7 @@@@ char *tok; /* buffer to place argument * /* nextarg: get the next argument */ -PASCAL NEAR nextarg(prompt, buffer, size, terminator) +int PASCAL NEAR nextarg(prompt, buffer, size, terminator) char *prompt; /* prompt to use if we must be interactive */ char *buffer; /* buffer to put token into */ @@@@ -263,7 +263,7 @@@@ int size; /* size of the buffer */ int terminator; /* terminating char to be used on interactive fetch */ { - register char *sp; /* return pointer from getval() */ + register CONST char *sp; /* return pointer from getval() */ /* if we are interactive, go get it! */ if (clexec == FALSE) { @@@@ -290,7 +290,7 @@@@ int terminator; /* terminating char to /* storeproc: Set up a procedure buffer and flag to store all executed command lines there */ -PASCAL NEAR storeproc(f, n) +int PASCAL NEAR storeproc(f, n) int f; /* default flag */ int n; /* macro number to use */ @@@@ -361,7 +361,7 @@@@ int n; /* macro number to use */ /* execproc: Execute a procedure */ -PASCAL NEAR execproc(f, n) +int PASCAL NEAR execproc(f, n) int f, n; /* default flag and numeric arg */ @@@@ -395,7 +395,7 @@@@ int f, n; /* default flag and numeric ar /* execbuf: Execute the contents of a buffer of commands */ -PASCAL NEAR execbuf(f, n) +int PASCAL NEAR execbuf(f, n) int f, n; /* default flag and numeric arg */ @@@@ -436,7 +436,7 @@@@ int f, n; /* default flag and numeric ar *LBL01 */ -PASCAL NEAR dobuf(bp) +int PASCAL NEAR dobuf(bp) BUFFER *bp; /* buffer to execute */ @@@@ -468,6 +468,10 @@@@ BUFFER *bp; /* buffer to execute */ VDESC vd; /* variable num/type */ char value[NSTRING]; /* evaluated argument */ + /* there's an error path where these are used but not set otherwise */ + ut = NULL; + einit = NULL; + /* clear IF level flags/while ptr */ execlevel = 0; whlist = NULL; @@@@ -971,7 +975,7 @@@@ LINE *lp; /* line " */ if $debug == TRUE, The interactive debugger is invoked commands are listed out with the ? key */ -PASCAL NEAR debug(bp, eline, skipflag) +int PASCAL NEAR debug(bp, eline, skipflag) BUFFER *bp; /* buffer to execute */ char *eline; /* text of line to debug */ @@@@ -1110,14 +1114,14 @@@@ WHBLOCK *wp; /* head of structure to fre } } -PASCAL NEAR execfile(f, n) /* execute a series of commands in a file */ +int PASCAL NEAR execfile(f, n) /* execute a series of commands in a file */ int f, n; /* default flag and numeric arg to pass on to file */ { register int status; /* return status of name query */ char fname[NSTRING]; /* name of file to execute */ - char *fspec; /* full file spec */ + CONST char *fspec; /* full file spec */ #if WINDOW_MSWIN /* special case: we want filenamedlg to refrain from stuffing a @@@@ -1161,9 +1165,9 @@@@ exec1: /* otherwise, execute it */ /* dofile: yank a file into a buffer and execute it if there are no errors, delete the buffer on exit */ -PASCAL NEAR dofile(fname) +int PASCAL NEAR dofile(fname) -char *fname; /* file name to execute */ +CONST char *fname; /* file name to execute */ { register BUFFER *bp; /* buffer to place file to exeute */ @