head	1.1;
access;
symbols
	pkgsrc-2026Q1:1.1.0.108
	pkgsrc-2026Q1-base:1.1
	pkgsrc-2025Q4:1.1.0.106
	pkgsrc-2025Q4-base:1.1
	pkgsrc-2025Q3:1.1.0.104
	pkgsrc-2025Q3-base:1.1
	pkgsrc-2025Q2:1.1.0.102
	pkgsrc-2025Q2-base:1.1
	pkgsrc-2025Q1:1.1.0.100
	pkgsrc-2025Q1-base:1.1
	pkgsrc-2024Q4:1.1.0.98
	pkgsrc-2024Q4-base:1.1
	pkgsrc-2024Q3:1.1.0.96
	pkgsrc-2024Q3-base:1.1
	pkgsrc-2024Q2:1.1.0.94
	pkgsrc-2024Q2-base:1.1
	pkgsrc-2024Q1:1.1.0.92
	pkgsrc-2024Q1-base:1.1
	pkgsrc-2023Q4:1.1.0.90
	pkgsrc-2023Q4-base:1.1
	pkgsrc-2023Q3:1.1.0.88
	pkgsrc-2023Q3-base:1.1
	pkgsrc-2023Q2:1.1.0.86
	pkgsrc-2023Q2-base:1.1
	pkgsrc-2023Q1:1.1.0.84
	pkgsrc-2023Q1-base:1.1
	pkgsrc-2022Q4:1.1.0.82
	pkgsrc-2022Q4-base:1.1
	pkgsrc-2022Q3:1.1.0.80
	pkgsrc-2022Q3-base:1.1
	pkgsrc-2022Q2:1.1.0.78
	pkgsrc-2022Q2-base:1.1
	pkgsrc-2022Q1:1.1.0.76
	pkgsrc-2022Q1-base:1.1
	pkgsrc-2021Q4:1.1.0.74
	pkgsrc-2021Q4-base:1.1
	pkgsrc-2021Q3:1.1.0.72
	pkgsrc-2021Q3-base:1.1
	pkgsrc-2021Q2:1.1.0.70
	pkgsrc-2021Q2-base:1.1
	pkgsrc-2021Q1:1.1.0.68
	pkgsrc-2021Q1-base:1.1
	pkgsrc-2020Q4:1.1.0.66
	pkgsrc-2020Q4-base:1.1
	pkgsrc-2020Q3:1.1.0.64
	pkgsrc-2020Q3-base:1.1
	pkgsrc-2020Q2:1.1.0.60
	pkgsrc-2020Q2-base:1.1
	pkgsrc-2020Q1:1.1.0.40
	pkgsrc-2020Q1-base:1.1
	pkgsrc-2019Q4:1.1.0.62
	pkgsrc-2019Q4-base:1.1
	pkgsrc-2019Q3:1.1.0.58
	pkgsrc-2019Q3-base:1.1
	pkgsrc-2019Q2:1.1.0.56
	pkgsrc-2019Q2-base:1.1
	pkgsrc-2019Q1:1.1.0.54
	pkgsrc-2019Q1-base:1.1
	pkgsrc-2018Q4:1.1.0.52
	pkgsrc-2018Q4-base:1.1
	pkgsrc-2018Q3:1.1.0.50
	pkgsrc-2018Q3-base:1.1
	pkgsrc-2018Q2:1.1.0.48
	pkgsrc-2018Q2-base:1.1
	pkgsrc-2018Q1:1.1.0.46
	pkgsrc-2018Q1-base:1.1
	pkgsrc-2017Q4:1.1.0.44
	pkgsrc-2017Q4-base:1.1
	pkgsrc-2017Q3:1.1.0.42
	pkgsrc-2017Q3-base:1.1
	pkgsrc-2017Q2:1.1.0.38
	pkgsrc-2017Q2-base:1.1
	pkgsrc-2017Q1:1.1.0.36
	pkgsrc-2017Q1-base:1.1
	pkgsrc-2016Q4:1.1.0.34
	pkgsrc-2016Q4-base:1.1
	pkgsrc-2016Q3:1.1.0.32
	pkgsrc-2016Q3-base:1.1
	pkgsrc-2016Q2:1.1.0.30
	pkgsrc-2016Q2-base:1.1
	pkgsrc-2016Q1:1.1.0.28
	pkgsrc-2016Q1-base:1.1
	pkgsrc-2015Q4:1.1.0.26
	pkgsrc-2015Q4-base:1.1
	pkgsrc-2015Q3:1.1.0.24
	pkgsrc-2015Q3-base:1.1
	pkgsrc-2015Q2:1.1.0.22
	pkgsrc-2015Q2-base:1.1
	pkgsrc-2015Q1:1.1.0.20
	pkgsrc-2015Q1-base:1.1
	pkgsrc-2014Q4:1.1.0.18
	pkgsrc-2014Q4-base:1.1
	pkgsrc-2014Q3:1.1.0.16
	pkgsrc-2014Q3-base:1.1
	pkgsrc-2014Q2:1.1.0.14
	pkgsrc-2014Q2-base:1.1
	pkgsrc-2014Q1:1.1.0.12
	pkgsrc-2014Q1-base:1.1
	pkgsrc-2013Q4:1.1.0.10
	pkgsrc-2013Q4-base:1.1
	pkgsrc-2013Q3:1.1.0.8
	pkgsrc-2013Q3-base:1.1
	pkgsrc-2013Q2:1.1.0.6
	pkgsrc-2013Q2-base:1.1
	pkgsrc-2013Q1:1.1.0.4
	pkgsrc-2013Q1-base:1.1
	pkgsrc-2012Q4:1.1.0.2
	pkgsrc-2012Q4-base:1.1;
locks; strict;
comment	@# @;


1.1
date	2012.12.28.03.03.09;	author dholland;	state Exp;
branches;
next	;


desc
@@


1.1
log
@Fix legacy C. Pass -Wall -W -Wmissing-declarations -Wwrite-strings on
gcc45.

   - avoid implicit int, declare void functions void
   - return values from non-void functions
   - put most external declarations properly in header files
   - use some static and const
   - fix up a big mess with function pointer casting
   - use standard includes, don't provide own decls of standard functions
   - use types matching libc when providing own malloc, printf, and putchar
   - use <ctype.h> functions correctly
   - silence assorted compiler warnings
   - fix some bugs exposed by compiler warnings
   - don't intentionally exercise signed overflow
   - remove some unused items
   - add patch comments to other patch (patch-aa)

As this includes several fixes and removes some undefined behavior on
a commonly reachable code path, bump PKGREVISION.
@
text
@$NetBSD$

- declare void functions void
- use const for string constants

--- ex_unix.c~	2003-09-03 19:53:02.000000000 +0000
+++ ex_unix.c
@@@@ -95,6 +95,7 @@@@ static char sccsid[] = "@@(#)ex_unix.c	1.
  * First part of a shell escape,
  * parse the line, expanding # and % and ! and printing if implied.
  */
+void
 unix0(warn)
 	bool warn;
 {
@@@@ -217,7 +218,8 @@@@ uexp:
  */
 ttymode
 unixex(opt, up, newstdin, mode)
-	char *opt, *up;
+	const char *opt;
+	char *up;
 	int newstdin, mode;
 {
 	int pvec[2];
@@@@ -299,6 +301,7 @@@@ unixex(opt, up, newstdin, mode)
  * F is for restoration of tty mode if from open/visual.
  * C flags suppression of printing.
  */
+void
 unixwt(c, f)
 	bool c;
 	ttymode f;
@@@@ -328,6 +331,7 @@@@ unixwt(c, f)
  * the filter, then a child editor is created to write it.
  * If output is catch it from io which is created by unixex.
  */
+void
 filter(mode)
 	register int mode;
 {
@@@@ -391,6 +395,7 @@@@ filter(mode)
  * Set up to do a recover, getting io to be a pipe from
  * the recover process.
  */
+void
 recover()
 {
 	static int pvec[2];
@@@@ -420,6 +425,7 @@@@ recover()
 /*
  * Wait for the process (pid an external) to complete.
  */
+void
 waitfor()
 {
 	int stat = 0;
@@@@ -449,6 +455,7 @@@@ waitfor()
  * exits non-zero, force not edited; otherwise force
  * a write.
  */
+void
 revocer()
 {
 
@